-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor update-lack on style change in EditDialog #2204
Comments
Same if you browse a table, click into a cell - EditDock shows cell-data, change main tab to pragmas and change to/from dark style - EditDock is not gonna be refreshed immediately. |
I had a lot of problems reapplying settings to the QScintilla widget. Either it is broken or I don't understand the logic. |
@mgrojo , I think there are different minor refresh issues related to the EditDock and, sorry, I don't realy think its the widget itself. What I don't understand: When I select a cell in the Data Browser - than switch to Strucutre Tab - the EditDialog is allready showing the last selected value - switching back to the Data Browser it changes to a value, that is not realy inside the selected table. |
When clicking on a cell with a NULL value while, the Edit dialog switches into text mode and shows an empty text with "NULL" written in the line number margin. When then changing to an empty string cell, the text in the editor did not change (it is still empty after all). This prevented an action from triggering which meant that the "NULL" text in the line number marging was not removed. See issue #2204.
I'm not 100% sure I can follow you because on your screenshots you don't show the cells you click. But here's what I think I understood:
This issue should be solved with the latest commit. Can you double check it's working and confirm that's the issue you meant 😄 Do you know if this issue already existed in version 3.11.2? |
When clicking on a cell with a NULL value while, the Edit dialog switches into text mode and shows an empty text with "NULL" written in the line number margin. When then changing to an empty string cell, the text in the editor did not change (it is still empty after all). This prevented an action from triggering which meant that the "NULL" text in the line number marging was not removed. See issue #2204.
Details for the issue
when you change style and EditDialog Value is null it doesn’t change
![grafik](https://user-images.githubusercontent.com/28151942/80028366-519f6800-84e5-11ea-884b-a67ab45bd2bb.png)
when EditDialog Value isn’t null, it works fine
![grafik](https://user-images.githubusercontent.com/28151942/80028400-59f7a300-84e5-11ea-8227-2121c90d2712.png)
after swapping to table (filled) and back to empty SQL-Tab everthing is fine)
![grafik](https://user-images.githubusercontent.com/28151942/80028428-5f54ed80-84e5-11ea-9365-aa529e401176.png)
works both ways the same: dark to light and light to dark
![grafik](https://user-images.githubusercontent.com/28151942/80028464-6aa81900-84e5-11ea-9dfc-7120c78286d6.png)
Useful extra information
The info below often helps, please fill it out if you're able to. :)
What operating system are you using?
What is your DB4S version?
Did you also
The text was updated successfully, but these errors were encountered: