Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update-lack on style change in EditDialog #2204

Open
1 task
horst-p-w-neubauer opened this issue Apr 22, 2020 · 4 comments
Open
1 task

minor update-lack on style change in EditDialog #2204

horst-p-w-neubauer opened this issue Apr 22, 2020 · 4 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs. gui

Comments

@horst-p-w-neubauer
Copy link
Member

Details for the issue

when you change style and EditDialog Value is null it doesn’t change
grafik

when EditDialog Value isn’t null, it works fine
grafik

after swapping to table (filled) and back to empty SQL-Tab everthing is fine)
grafik

works both ways the same: dark to light and light to dark
grafik

Useful extra information

The info below often helps, please fill it out if you're able to. :)

What operating system are you using?

  • [x ] Windows: ( _version:_7 ___ )

What is your DB4S version?

  • [ x] 3.12.0-(alpha or betas)

Did you also

@horst-p-w-neubauer
Copy link
Member Author

Same if you browse a table, click into a cell - EditDock shows cell-data, change main tab to pragmas and change to/from dark style - EditDock is not gonna be refreshed immediately.

@mgrojo mgrojo added bug Confirmed bugs or reports that are very likely to be bugs. gui labels May 6, 2020
@mgrojo
Copy link
Member

mgrojo commented May 6, 2020

I had a lot of problems reapplying settings to the QScintilla widget. Either it is broken or I don't understand the logic.

@horst-p-w-neubauer
Copy link
Member Author

@mgrojo , I think there are different minor refresh issues related to the EditDock and, sorry, I don't realy think its the widget itself.
If I add
editDock->setCurrentIndex(QModelIndex());
after
editDock->reloadSettings();
in void MainWindow::reloadSettings()
it works - but thats probably only an workarround - not a solution.

What I don't understand: When I select a cell in the Data Browser - than switch to Strucutre Tab - the EditDialog is allready showing the last selected value - switching back to the Data Browser it changes to a value, that is not realy inside the selected table.

MKleusberg added a commit that referenced this issue Jun 3, 2020
When clicking on a cell with a NULL value while, the Edit dialog
switches into text mode and shows an empty text with "NULL" written in
the line number margin. When then changing to an empty string cell, the
text in the editor did not change (it is still empty after all). This
prevented an action from triggering which meant that the "NULL" text in
the line number marging was not removed.

See issue #2204.
@MKleusberg
Copy link
Member

I'm not 100% sure I can follow you because on your screenshots you don't show the cells you click. But here's what I think I understood:

  • Click any cell with NULL value -> the Edit dialog shows "NULL" in the line number area of the text editor
  • Click a cell with an empty string value -> the Edit dialog still shows "NULL" in the line number area

This issue should be solved with the latest commit. Can you double check it's working and confirm that's the issue you meant 😄 Do you know if this issue already existed in version 3.11.2?

mgrojo pushed a commit that referenced this issue Aug 22, 2020
When clicking on a cell with a NULL value while, the Edit dialog
switches into text mode and shows an empty text with "NULL" written in
the line number margin. When then changing to an empty string cell, the
text in the editor did not change (it is still empty after all). This
prevented an action from triggering which meant that the "NULL" text in
the line number marging was not removed.

See issue #2204.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs. gui
Projects
None yet
Development

No branches or pull requests

3 participants