-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Load or export user configuration file in a GUI environment #2393
Comments
Having it off the File menu is slightly confusing, considering to get to the configuration, you go to the Edit menu, and select 'Preferences'. Preferences ... configuration ... is this the same thing? This might mean the command-line switch needs to be reworded to 'preferences file' and not 'config file'. Or maybe a config file holds preference information, so thats OK. Heck, I hate this, and swear in my applications when I've added a 'New...' button in one form then an 'Add...' in another. Just a thought though ... so please don't take any notice of my ramblings! 😆 |
@chrisjlocke I think your idea is nice. 😄 I think it would be nice to create a new tab in the preferences dialog and implement the function I was talking and move the existing 'Restore Defaults' button. Preferences? Configuration? I'm also wondering which word will be more natural. Personally, I think it would be good to express it as an 'Preferences' than 'Configuration' (Because it is already express as an Preferences and PreferencesDialog) I simply implemented the prototype. What do you think? |
Personally, I kind of like the concept of those two buttons in @chrisjlocke's first screenshot: But probably named "Export Preferences" and "Import Preferences", as they're already in the "Preferences" dialog? |
Cool, then we better add two buttons at the bottom. |
Yeah, probably best to try and keep things consistent. 😄 |
Cool. Then it's time to tap on the keyboard! |
@justinclift I'm sorry to keep bothering you. Shall I change the name of the environment variable 'DB4S_CONFIG_FILE' too? |
I'm not a DB4S programmer, but it would help reading the code, especially for others. |
Change to 'Preferences' expression instead of 'Configuration' expression for consistent. See the issue #2393
I agree. For the consistent, I changed the name of the environment variable and committed it. d9fd0e1 |
Sorry to introduce more doubt but in fact, the settings include more
information than only the preferences like many settings that are adjusted
directly by the user in the application, like window layout, state of some
toggle buttons and the like. Might be irrelevant, but I wonder if user will
be surprised by that if we call it preferences.
On the other hand, what is this suppose to do? Import the configuration in
the file into the native "registry" or set the file as the settings store
for the rest of the session? "Import" suggests the former, but then, it is
something different to what one gets from the command line. Saying that
because it should not be called import if it's the same as the "-c" switch.
But what users would like from the GUI is something permanent, so a real
import is what we need.
|
@mgrojo Thanks for the comments. I'd like to give my thoughts on which expression would be more appropriate, 'Configuration' and 'Preferences', but it's difficult to comment because English is not my native language. and about on the second agenda I think it is because I simply came up with the word 'Import' without thinking of the word 'Load'. (similar reaons as above) I think it's good to give multiple options to user, but on the one hand, I think it might be better to just store permanently ('real import' in your expression) as you say. What do other people think? 😄 |
Yeah, that's a good point. If it does more than just preferences, we probably do need to use a different word. 🤔 |
@justinclift - word your reaching for is settings There are a few schools of thought about where to put menu entry. By convention, and assume you have a choice unlike MacOS, choices are File, Help, and Edit. Since we're dealing with an application level construct, my choice would be for the File menu. Also, Menu Item separators coupled with ellipses at end of action name (i.e. "Edit Settings...") can be employed to ensure this stands out or otherwise doesn't causes confusion. My €/$0.02 |
Settings sound reasonable. Am kind of thinking "Export Settings" and "Import Settings" buttons (as per above button screenshots), unless that'd be too confusing to have in the Preferences dialog? |
On 2020-09-07 2:31 p.m., Justin Clift wrote:
/Settings/ sound reasonable. Am kind of thinking "Export Settings" and
"Import Settings" buttons (as per above button screenshots), unless
that'd be too confusing to have in Preferences dialog?
This works. Analogous to Firefox where Export/Import bookmarks are apart
of Bookmarks manager dialog.
Extra buttons on the bottom maybe?
|
I also searched the English-English dictionary, but 'Settings' seems to be a more appropriate expression. In summary, is it correct to express it as 'Settings', and to make the buttons at the bottom of the |
Preferences would be something more user-centric. Eg, the toolbar style you want, the font size, etc. Settings would be more application-centric - window size, date last updated, etc. The configuration would be what the application needs to work, eg, variables that can be tweaked/set, URLs it points to, etc. There is a lot of grey area though - one configuration option could be a preference, etc, etc. Its all up to different developers and the OS they use. Eg, in Windows, everthing was Options. 'Tools' -> 'Options' has been a standard in Microsoft stuff for years. Linux has been 'Preferences' or 'Settings', etc. I don't think changing the name of the dialog would be necessary... |
@chrisjlocke I understand. I just mentioned it for consistent. 😉 |
Describe the new feature
I recently made a change to user can use a user configuration file with code I committed. 0644bc0
However, it still only works on the command line. Working from the command line would be inconvenient for most users compared to GUI environments. In fact, there were some people who used this program for education in related issues.
So I propose to provide two menus as follows in GUI environment.
and I will also provide the option to permanently save the configuration(Windows registry or specified path by QSettings class) so that the user doesn't load the configuration file every time they run the DB4S. What do you think? 😄
*It's not included in the screenshot, but it would be nice to warn that if click 'Yes', existing settings may be deleted.
Additional info
Please answer these questions before submitting your feature request.
Is your feature request related to an issue? Please include the issue number.
#2317
Does this feature exist in another product or project? Please provide a link.
Many
Do you have a screenshot? Please add screenshots to help explain your idea.
Already attached above.
The text was updated successfully, but these errors were encountered: