Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: sql editor font selection #299

Closed
AGlezB opened this issue May 6, 2015 · 11 comments
Closed

feature request: sql editor font selection #299

AGlezB opened this issue May 6, 2015 · 11 comments
Labels
enhancement Feature requests.

Comments

@AGlezB
Copy link

AGlezB commented May 6, 2015

Since 3.6.0 sql editor font is not monospace. Please support font customization.

@justinclift
Copy link
Member

Just checked, and you're right. I hadn't realised our Preferences dialog doesn't allow a choice of font, it only allows size.

This sounds like a worthwhile enhancement. 😄

@justinclift justinclift added the enhancement Feature requests. label May 6, 2015
@AGlezB
Copy link
Author

AGlezB commented May 6, 2015

Wow! You just broke about every response time record I've ever heard of.

@justinclift
Copy link
Member

I was looking at GitHub anyway for other stuff. 😄

MKleusberg added a commit that referenced this issue May 6, 2015
@MKleusberg
Copy link
Member

This is kind of odd because we're still setting the font to Monospace. No idea why this doesn't get accepted on your system... It would be interesting to know which OS you're using and how exactly the font looks like on your system.
But either way, I've added a new option for setting the editor font to the Preferences Dialog. You'll find the new option in tomorrow's nightly build (see front page of the repository). Maybe manually setting the font already does the trick for you. Let us know if this works for you :)
Saludos a Chile! 😃

@justinclift
Copy link
Member

Wow. Now that's a good response time @MKleusberg. 😁

@AGlezB
Copy link
Author

AGlezB commented May 6, 2015

Indeed! 👏 @MKleusberg

How do I set the font manually?

OS: Win 8.1 Pro 64 (6.3.9600)

3.5.1
sql-editor-font-3 5 1

3.6.0
sql-editor-font-3 6 0

@justinclift
Copy link
Member

Hmmm, you might need to wait until the automatic build tonight?

@MKleusberg
Copy link
Member

Yes, you'll need to wait for the nightly build. See details here: https://github.com/sqlitebrowser/sqlitebrowser#windows
The build should be there in ~6h. If you use the binary from that link you can click View->Preferences, then click the SQL tab, and edit the 'SQL editor font' option.

font

@AGlezB
Copy link
Author

AGlezB commented May 6, 2015

Thanks. I'll let you know you nailed it as soon as I can. 😄

@AGlezB
Copy link
Author

AGlezB commented May 7, 2015

Nailed it. Not that there was any doubt about it. 😁
👍 @justinclift, @MKleusberg

@justinclift
Copy link
Member

Awesome. 😀

Thanks for checking and letting us know, it really helps. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests.
Projects
None yet
Development

No branches or pull requests

3 participants