New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close button & other enhancement #331
Comments
Hmmm, I have no strong objection to adding a Close database" button. It would be useful for people. The idea of having a list (in Preferences area?) to allow customisation of buttons does sound really good though. 😄 Out of curiosity, do you have skill with C++ and/or Qt? 😄 |
I don't know about Qt |
That would be great. 😀 |
I think we have space in the DB toolbar for adding more buttons, like close, attach, etc. Regarding customization, it is not simple to do, except if we leave the setting at the toolbar level. I think we could add one or more toolbars and let the user configure which one he/she wants to view. The only contra is that he/she will only free up space when all the toolbars are disabled (I personally hide the DB toolbar). We could add an Extra DB Toolbar (Close, Attach) and a Project Toolbar (Open, Save), or do whatever reorganization of the current tool buttons, for example:
If this is welcome I could contribute the implementation. |
Yeah, I'd welcome us having some extra buttons on the toolbar too. Bearing in mind the UI still needs to "look approachable" for new users who are unskilled with SQLite (or even SQL in general). That shouldn't be too hard to manage though. 😄 |
Two new application toolbars: Extra DB (attach, close database) and Project (Open, Save). Can be disabled and moved as usual. Icons for Close Database and Attach Database actions, which lacked ones. Different icon for the dock configuration, so they are visually distinguishable from the toolbar configurations. New preference for the toolbar style, with default value: text besides icon as before. But in order for the style to change, the value in UI must be ToolButtonIconOnly. Needed new icons from famfamfam.com's Silk collection. See related issue #331
@tbayart Are you still using DB browser for SQLite? We've finally added the Close Database button among other improvements like two new toolbars and toolbar style configuration. If you'd like to take a look at the new version, you can try with the nightly build: https://nightlies.sqlitebrowser.org/latest/ |
Hi, I'm not using sqlitebrowser actually. |
Thanks for testing it, @tbayart. We can close this issue now. |
Just tried this out quickly, and it looks great. Still looks friendly for new users too (my opinion). 😄 Awesome stuff @mgrojo. 😄 |
Not sure if "DB Toolbar", "Extra DB Toolbar", and "Project Toolbar" in the View menu are the optimal wording choices... but I'm not thinking of any better ones either at the moment. Those are good enough to start with. 😄 |
Thanks, @justinclift 👍 The wording and grouping of buttons in toolbars could be changed easily. I wrote another idea for the grouping above, but finally didn't want to touch the current DB toolbar, just in case people is accustomed to it. But then the Extra DB has a somewhat arbitrary division and naming 😄 |
Just a slight 'worry' is that now the 'Open Project' and 'Save Project' have been removed from the 'File' menu, it reduces the accessibility of the product for non-mouse users. I can't see many non-mouse users using the product, but I've always been taught (although the design spec is shifting) that the menu options should house all available options, regardless of whether there are menu buttons for them (which can't be easily accessed via the keyboard alone). |
@chrisjlocke Thanks for pointing this out. Specially the one about Open Project and Save Project. You can consider them bugs. My intention was to copy them to the toolbar. You have to press control while you drag and drop them in qtcreator, otherwise they are moved. They are the same object, so all the properties in the menu are also set in the toolbar. I'll rectify that and take a look to the other mentioned issues. |
The inconsistencies should be fixed now with a4728ff. (I forgot to reference this issue) I haven't changed the 'Choose a file to open' message. Not sure about it. We have also this:
Maybe: 'Choose a project file to open' ? |
"Choose a project file to open" sounds good to me. 😄 |
Let's close this since all the commented issues are addressed. If anyone has good ideas on how to distribute or name the toolbars can feel free to open a new issue or reopen this one. |
Hi, I would like to suggest a "Close database" button beside the "new" and "open" buttons.
A better enhancement would be a tab in settings to select active buttons in a list of possibilities allowing users a bit of customization.
The text was updated successfully, but these errors were encountered: