New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore QTextEdit widget for RTL text in the Cell Editor #1929
Conversation
This restores the Qt text widget that was replaced by a QScintilla one in 45c1e2a QScintilla does not support right-to-left scripts like Arabic, so QTextEdit is still needed for these languages. Since the QScintilla editor has other advantages already explained, it is preserved for general text edition. RTL texts are detected when data is loaded and the Qt editor is automatically selected. This is done both when loading data from the cell and when interactively typing RTL characters in the Cell Editor. All these changes can be undone if a new QScintilla editor supports RTL texts. See comments in issue #1793
Yeah, sounds like this will be the way to go, until QScintilla supports RTL languages. Hopefully some day. 😄 Thanks for putting the time in for this @mgrojo. It can be a bit disappointing when a good idea doesn't work out. 😦 |
I make these pull request so users working with right-to-left languages can provide feedback before merging. @Johntaa can you compile from sources or would you need a build from this branch? I'd like to know if the work flow displaying and entering RTL texts is correct. |
Wow, Thank you for taking this step , it is greatly appreciated. I prefer a build from this branch. |
(void message)
|
1 similar comment
(void message)
|
And what operating system are you using, @Johntaa? In any case I think we'd need help from @justinclift. |
Win64 |
@Z4us ??? @mgrojo Thanks. 😄 @Johntaa Win64 build:
Pick whichever of those appeals to you. 😄 |
@justinclift , Thank you . |
Ok, I'll make a change in the RTL text detetion and I hope it will work better. The workaround for the current behaviour would be to change to the manual mode (button with the cog) and selecting RTL Text before writing the cell content.
This is configurable and it's the same for both widgets. There is button with a white page with text lines, which can be used to switch between scrolled lines or word wrapp. |
@Johntaa, mixed Latin and Arabic texts should work now. Could you test and confirm? @justinclift, we would need another build of this branch. |
@mgrojo : tested using sample database with both Latin and Arabic characters , working great. I don't see any problem. Thanks. |
Thanks, @Johntaa. Then I suppose this branch could be merged now, because the code is mostly recovered from previous versions with minor additions. I will wait till tomorrow, though, just in case someone would like to make a review. |
Good stuff @mgrojo. 😄 |
This restores the Qt text widget that was replaced by a QScintilla one in
45c1e2a
QScintilla does not support right-to-left scripts like Arabic, so QTextEdit
is still needed for these languages. Since the QScintilla editor has other
advantages already explained, it is preserved for general text edition.
RTL texts are detected when data is loaded and the Qt editor is
automatically selected. This is done both when loading data from the cell
and when interactively typing RTL characters in the Cell Editor.
All these changes can be undone if a new QScintilla editor supports RTL
texts.
See comments in issue #1793