Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Japanese file to v3.12.1 #2407

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Update the Japanese file to v3.12.1 #2407

merged 2 commits into from
Sep 18, 2020

Conversation

hrwatahiki
Copy link
Contributor

Update the Japanese file to v3.12.1

@hrwatahiki hrwatahiki mentioned this pull request Sep 18, 2020
Closed
lucydodo
lucydodo requested changes Sep 18, 2020
View reviewed changes
Copy link
Member

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing! 😄
I found two items that needed simple corrections.
I could only edit those parts and merge them, but I left it as a review only as you may have disagreements. Check them please.

src/translations/sqlb_ja.ts Outdated Show resolved Hide resolved
src/translations/sqlb_ja.ts Outdated Show resolved Hide resolved
@lucydodo lucydodo added this to the 3.12.1 milestone Sep 18, 2020
@hrwatahiki
Copy link
Contributor Author

@lucydodo
Sorry. I removed translated shortcuts you quoted.

@lucydodo lucydodo merged commit 433caeb into sqlitebrowser:v3.12.x Sep 18, 2020
@lucydodo
Copy link
Member

Thanks! Now squash and merged.

@hrwatahiki
Copy link
Contributor Author

Thanks! 😊

mgrojo added a commit that referenced this pull request Nov 23, 2020
@mgrojo
Update the Japanese translation for v3.12.1 (#2407)
c894c4c 
* Update the Japanese translation for v3.12.1
* Remove translated shortcuts.

Cherry-picked from v3.12.x branch.

# Conflicts:
#	src/translations/sqlb_ja.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucydodo lucydodo lucydodo requested changes

Assignees
No one assigned
Labels
translation
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hrwatahiki @lucydodo