Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect loading of .env #3594

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fix incorrect loading of .env #3594

merged 1 commit into from
Mar 26, 2024

Conversation

mgrojo
Copy link
Member

@mgrojo mgrojo commented Mar 25, 2024

Custom format is not loading the fields and implementation is not justified as the .env format is basically a simplification of the IniFormat.

Tested with:

  • Built for x86_64-little_endian-lp64, running on x86_64
  • Qt Version 5.15.3
  • SQLCipher Version 3.4.1 (based on SQLite 3.15.2).

Tested no regression for #3083.

Custom format is not loading the fields and implementation is not justified
as the .env format is basically a simplification of the IniFormat.

Tested with:

- Built for x86_64-little_endian-lp64, running on x86_64
- Qt Version 5.15.3
- SQLCipher Version 3.4.1 (based on SQLite 3.15.2).

Tested no regression for #3083.
@justinclift
Copy link
Member

@revolter Hey dude, any interest in looking at this? You're the original author of this .env loading code, and it sounds like there's a bug that needs fixing? 😄

Copy link
Member

@revolter revolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job simplifying the implementation 💪🏻 ❤️

src/DotenvFormat.cpp Show resolved Hide resolved
src/sqlitedb.cpp Show resolved Hide resolved
@justinclift
Copy link
Member

Cool, sounds like everyone's happy. I'll hit the merge button then... 😄

@justinclift justinclift merged commit 3e7dd41 into master Mar 26, 2024
11 checks passed
@justinclift justinclift deleted the fix-env-format branch March 26, 2024 22:27
@justinclift
Copy link
Member

Good work @mgrojo, and thanks for reviewing @revolter. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants