Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default value for window frame #313

Merged
merged 1 commit into from Aug 20, 2021

Conversation

Jimexist
Copy link
Contributor

@Jimexist Jimexist commented Jun 3, 2021

@andygrove please take a look, thanks!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 901793053

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • 21 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.1%) to 90.178%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/ast/data_type.rs 1 75.0%
src/ast/ddl.rs 2 80.18%
src/ast/query.rs 2 86.6%
src/parser.rs 4 85.89%
src/tokenizer.rs 4 91.18%
src/ast/mod.rs 8 70.83%
Totals Coverage Status
Change from base Build 676410191: 0.1%
Covered Lines: 5472
Relevant Lines: 6068

💛 - Coveralls

@Jimexist Jimexist force-pushed the add-default-for-window-frame branch from 0dd3c05 to 2723b9c Compare June 29, 2021 05:31
@alamb alamb force-pushed the add-default-for-window-frame branch from 2723b9c to 950daf3 Compare August 20, 2021 17:56
@alamb
Copy link
Collaborator

alamb commented Aug 20, 2021

I have rebased this PR to get the CI checks running, and if they pass I will merge it in

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1151595220

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 90.079%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 1151591467: 0.008%
Covered Lines: 5557
Relevant Lines: 6169

💛 - Coveralls

@alamb alamb merged commit 293133f into sqlparser-rs:main Aug 20, 2021
@Jimexist Jimexist deleted the add-default-for-window-frame branch August 22, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants