Move list initialisation to onCreate 🐛

squanchy-dev · Mar 29, 2017 · 4a98595 · 4a98595
1 parent 8f43b96
commit 4a98595
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/app/src/main/java/net/squanchy/about/licenses/LicensesActivity.java b/app/src/main/java/net/squanchy/about/licenses/LicensesActivity.java
@@ -23,18 +23,6 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
         setupToolbar();
 
         licensesList = (RecyclerView) findViewById(R.id.libraries_list);
-    }
-
-    private void setupToolbar() {
-        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
-        setSupportActionBar(toolbar);
-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
-        getSupportActionBar().setDisplayShowTitleEnabled(true);
-    }
-
-    @Override
-    protected void onStart() {
-        super.onStart();
 
         licensesList.setAdapter(new LibrariesAdapter(this));
         licensesList.setLayoutManager(new LinearLayoutManager(this));
@@ -44,6 +32,13 @@ protected void onStart() {
         licensesList.addItemDecoration(new CardSpacingItemDecorator(horizontalSpacing, verticalSpacing));
     }
 
+    private void setupToolbar() {
+        Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
+        setSupportActionBar(toolbar);
+        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
+        getSupportActionBar().setDisplayShowTitleEnabled(true);
+    }
+
     @Override
     public boolean onOptionsItemSelected(MenuItem item) {
         if (item.getItemId() == android.R.id.home) {