This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
SQ-55/notifications settings #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That isn't the correct icon FYI but for now it's ok -- this is the correct one: |
rock3r
approved these changes
Mar 16, 2017
| case R.id.action_settings: | ||
| navigate.toSettings(); | ||
| return true; | ||
| default: |
There was a problem hiding this comment.
This seems to need a cmd-alt-l
|
|
||
| </android.support.design.widget.AppBarLayout> | ||
|
|
||
| <FrameLayout |
There was a problem hiding this comment.
Could've put the <fragment ... /> here directly I suppose, but whatevs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the
SettingsActivity.It's possible to access this from the Schedule screen (with dedicated menu item).
For now it only contains a toggle to enable/disable notifications for upcoming events.
We check for that preference status in the notifications service.