Skip to content
This repository has been archived by the owner on Feb 17, 2020. It is now read-only.

SQ-154/fix notification crash #155

Merged
merged 3 commits into from
Mar 21, 2017
Merged

Conversation

tiwiz
Copy link
Contributor

@tiwiz tiwiz commented Mar 21, 2017

Fixes the notification on Lollipop, that were crashing due to method not being found (as per Issue #154 ) and removes the chronometer, as it was behaving strangely on HTC devices.

Before After
htc_rompe_le_cose e_roby_le_aggiusta

@tiwiz tiwiz requested a review from danybony March 21, 2017 11:33
@tiwiz tiwiz changed the title Sq 154/fix notification crash SQ-154/fix notification crash Mar 21, 2017
Copy link
Collaborator

@rock3r rock3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@danybony danybony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -53,7 +54,6 @@ private Notification createFrom(Event event) {
.setContentTitle(event.title())
.setContentText(getPlaceName(event))
.setColor(getTrackColor(event))
.setUsesChronometer(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@danybony danybony merged commit 150c2f7 into develop Mar 21, 2017
@danybony danybony deleted the SQ-154/fix_notification_crash branch March 21, 2017 11:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants