SQ-166/Empty state(s) for favourites #188

alexstyl · 2017-03-28T21:55:55Z

This PR includes empty states for the favorite screen.

When the user is logged out, we prompt them to sign in.
When they are logged in, we teach them how to favorite talks.

Screenshots

Before signing in

After signing in:

# Conflicts: # app/src/main/res/values/styles.xml

danybony

Great idea regarding the snackbar for the feedback 💯
There are some required changes

danybony · 2017-03-29T07:55:43Z

app/src/main/java/net/squanchy/favorites/FavoritesPageView.java

+    private void promptToFavorite() {
+        favoritesListView.setVisibility(GONE);
+        progressBar.setVisibility(GONE);
+


you can remove this empty line

danybony · 2017-03-29T07:55:47Z

app/src/main/java/net/squanchy/favorites/FavoritesPageView.java

+    public void promptToSign() {
+        favoritesListView.setVisibility(GONE);
+        progressBar.setVisibility(GONE);
+


you can remove this empty line

danybony · 2017-03-29T07:58:33Z

app/src/main/java/net/squanchy/favorites/FavoritesPageView.java

@@ -92,8 +104,53 @@ public void onStop() {
        subscription.dispose();
    }

-    public void updateWith(Schedule schedule, ScheduleViewPagerAdapter.OnEventClickedListener listener) {
+    private void updateWith(ScheduledAndSignedIn scheduledAndSignedIn, ScheduleViewPagerAdapter.OnEventClickedListener listener) {
+        if (scheduledAndSignedIn.hasPages()) {


This is leaking the fact that Schedule contains pages IMHO (I totally forgot about that TBH and it doesn't feel needed here).
I think that a isEmpty() or hasSchedule() would be better

danybony · 2017-03-29T07:59:50Z

app/src/main/java/net/squanchy/favorites/FavoritesPageView.java

                .observeOn(AndroidSchedulers.mainThread())
                .subscribe(schedule -> updateWith(schedule, this::onEventClicked));
    }

+    private BiFunction<Schedule, Boolean, ScheduledAndSignedIn> toScheduleAndLoggedInStuff() {


Stuff?
toScheduledAndSignedIn()

danybony · 2017-03-29T08:02:16Z

app/src/main/java/net/squanchy/favorites/view/NoFavoritesView.java

+
+public class NoFavoritesView extends LinearLayout {
+
+    private static final int MAGIC_NUMBER_TO_TRIGGER_ACHIEVEMENT = 5;


It is magic as in... magical ~ 💖

danybony · 2017-03-29T08:09:55Z

app/src/main/res/layout/merge_pretty_empty_view.xml

+    android:layout_height="wrap_content"
+    android:tint="?colorAccent"
+    android:src="@drawable/illustration_lunch"
+    android:contentDescription="Sad picture of a panda" />


Proper content description and extract to strings

TBH if it's not important for a11y we should simply not set one (@ataulm might confirm here)

danybony · 2017-03-29T08:10:04Z

app/src/main/res/layout/merge_pretty_empty_view.xml

+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content"
+    android:layout_margin="12dp"
+    android:text="We are sad and so should you" />


Proper text and extract to strings

danybony · 2017-03-29T08:10:13Z

app/src/main/res/layout/merge_pretty_empty_view.xml

+    android:id="@+id/label"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content"
+    android:layout_margin="12dp"


Extract to dimensions

danybony · 2017-03-29T08:10:32Z

app/src/main/res/layout/view_page_favorites.xml

+      android:layout_height="wrap_content"
+      android:drawableTop="@drawable/illustration_prompt_to_sign_in"
+      android:visibility="gone"
+      android:foreground="@drawable/card_touch_feedback"


danybony · 2017-03-29T08:12:09Z

app/src/main/res/layout/merge_pretty_empty_view.xml

@@ -0,0 +1,26 @@
+<merge xmlns:android="http://schemas.android.com/apk/res/android"


Where is this layout used?

rock3r · 2017-03-29T09:16:05Z

@alexstyl the build is failing:

/home/travis/build/rock3r/squanchy/app/src/main/res/layout/merge_no_favorites_view.xml:26:25-54: AAPT: No resource found that matches the given name (at 'foreground' with value '@drawable/card_touch_feedback').
    
/home/travis/build/rock3r/squanchy/app/src/main/res/layout/view_page_favorites.xml:51:27-56: AAPT: No resource found that matches the given name (at 'foreground' with value '@drawable/card_touch_feedback').
    
/home/travis/build/rock3r/squanchy/app/build/intermediates/res/merged/debug/layout/merge_no_favorites_view.xml:17: error: Error: No resource found that matches the given name (at 'foreground' with value '@drawable/card_touch_feedback').
/home/travis/build/rock3r/squanchy/app/build/intermediates/res/merged/debug/layout/view_page_favorites.xml:44: error: Error: No resource found that matches the given name (at 'foreground' with value '@drawable/card_touch_feedback').

Did you not push those changes?

ataulm · 2017-03-29T12:12:52Z

So confirmed

…

On Wed, 29 Mar 2017, 10:14 Sebastiano Poggi, ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In app/src/main/res/layout/merge_pretty_empty_view.xml <#188 (comment)>: > + android:id="@+id/empty_view" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:layout_gravity="center" + android:gravity="center_horizontal" + android:orientation="vertical" + tools:parentTag="LinearLayout"> + + <ImageView + + android:id="@+id/illustration" + android:layout_width="wrap_content" + android:layout_height="wrap_content" + android:tint="?colorAccent" + ***@***.***/illustration_lunch" + android:contentDescription="Sad picture of a panda" /> TBH if it's not important for a11y we should simply not set one ***@***.*** <https://github.com/ataulm> might confirm here) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#188 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACjfG06C0odpg4-gAEFo2iQs7qODGZUSks5rqiEOgaJpZM4MsPtf> .

alexstyl · 2017-03-29T12:14:27Z

app/src/main/java/net/squanchy/favorites/FavoritesPageView.java


        setupToolbar();
+
+        if (!isInEditMode()) {
+            Activity activity = unwrapToActivityContext(getContext());


This block was moved to the !isInEditMode() so that we can have a preview of this screen. As it turns out there is a specific kind of Context being used in the Preview mode and unwrapToActivityContext() is crashing because it is unhandled. The specific Context is BridgeContext and looks like a Hidden API, so we cannot possibly handle it properly

# Conflicts: # app/src/main/res/layout/view_page_schedule.xml # app/src/main/res/values/styles.xml

alexstyl added 8 commits March 28, 2017 21:16

Show empty view when no favorites are available

9692cca

Create references for illustrations

0fc70a3

Style for empty text

b35fefc

Some key renaming

34a6f2b

Show a dedicated empty view for favoriting

5128ba6

Add fun 🎉

346dbac

Remove obsolete reference

a1a7b44

Merge branch 'develop' into SQ-55/favorite-empty

92459d2

# Conflicts: # app/src/main/res/values/styles.xml

alexstyl changed the base branch from develop to SQ-55/feature_branch March 28, 2017 21:56

alexstyl changed the base branch from SQ-55/feature_branch to develop March 28, 2017 22:00

alexstyl changed the title ~~SQ-55/Empty state(s) for favourites~~ SQ-166/Empty state(s) for favourites Mar 28, 2017

danybony self-assigned this Mar 29, 2017

danybony suggested changes Mar 29, 2017

View reviewed changes

alexstyl and others added 10 commits March 29, 2017 13:01

Add missing primary_card_feedback_thing

855bddf

Add missing primary_card_feedback_thing (take2)

0b61006

Rename toScheduleAndLoggedInStuff to.. toScheduleAndLoggedIn!

4cfe216

Remove empty lines

4c71799

Throw exception when changing orientation

9e3857c

Remove the concept of pages from Schedule

5b0599d

Remove empty line

665e8cb

Remove unused layout

587834e

Extract attrs to style

53a2a9a

Merge branch 'develop' into SQ-55/favorite-empty

095e7ec

alexstyl commented Mar 29, 2017

View reviewed changes

alexstyl added 2 commits March 29, 2017 13:59

Merge branch 'develop' into SQ-55/favorite-empty

0c30a32

Merge branch 'develop' into SQ-55/favorite-empty

dfdd48b

danybony approved these changes Mar 29, 2017

View reviewed changes

Merge branch 'develop' into SQ-55/favorite-empty

c293cd7

# Conflicts: # app/src/main/res/layout/view_page_schedule.xml # app/src/main/res/values/styles.xml

rock3r added 2 commits March 29, 2017 17:34

Make sure favorites appear when just signed in

3e6478e

Fix event details not appearing

7bc837a

rock3r merged commit 2bac566 into develop Mar 29, 2017

rock3r deleted the SQ-55/favorite-empty branch March 29, 2017 16:44

rock3r mentioned this pull request Mar 29, 2017

Homescreen empty states #166

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQ-166/Empty state(s) for favourites #188

SQ-166/Empty state(s) for favourites #188

alexstyl commented Mar 28, 2017

danybony left a comment

danybony Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

alexstyl Mar 29, 2017

danybony Mar 29, 2017

rock3r Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

danybony Mar 29, 2017

rock3r commented Mar 29, 2017

ataulm commented Mar 29, 2017 via email

alexstyl Mar 29, 2017


		public class NoFavoritesView extends LinearLayout {

		private static final int MAGIC_NUMBER_TO_TRIGGER_ACHIEVEMENT = 5;

		@@ -0,0 +1,26 @@
		<merge xmlns:android="http://schemas.android.com/apk/res/android"

SQ-166/Empty state(s) for favourites #188

SQ-166/Empty state(s) for favourites #188

Conversation

alexstyl commented Mar 28, 2017

Screenshots

danybony left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rock3r commented Mar 29, 2017

ataulm commented Mar 29, 2017 via email

Choose a reason for hiding this comment