This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
SQ-60/Create location onboarding #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can reuse it in the onboarding
quiro91
reviewed
Mar 30, 2017
| android:layout_marginTop="@dimen/onboarding_logo_margin_top" | ||
| android:layout_marginEnd="@dimen/onboarding_content_margin_horizontal" | ||
| android:contentDescription="@null" | ||
| android:src="@drawable/google_primary" /> |
There was a problem hiding this comment.
since we already had issues with vector drawables can we just use app:srcCompat ?
There was a problem hiding this comment.
Ooops totally forgot :P
quiro91
approved these changes
Mar 30, 2017
| @@ -26,51 +27,48 @@ | |||
|
|
|||
| public class Navigator { | |||
|
|
|||
| private final Context context; | |||
| private static final int NO_FLAGS = 0; | |||
There was a problem hiding this comment.
shouldn't there be an empty line between static final fields and other fields?
There was a problem hiding this comment.
...yes there should. Will fix in next PR, takes too much to do a CI build for this XD
tiwiz
approved these changes
Mar 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the basic framework for onboarding and the MVP for the location onboarding.
TODO:
HomeActivity) to check and re-request permissions/BT as neededProximityFeaturethat enables the proximity stuff (including the onboarding!) IIF: