This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
Use Glide's native circleCrop() transform #597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are using a bunch of custom stuff to get circle cropped images but we don't need it anymore since Glide 4.0 introduced its own built-in for that.
Solution
We ain't needing
CircleImageView
anymore! Switch to the Glide built-in.Test(s) added
Nope.
Screenshots
No UI changes.
Paired with
Nobody