This repository has been archived by the owner on Jun 13, 2024. It is now read-only.
Making configure static #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanse/Subcomponent.swift
Outdated
| @@ -1,5 +1,5 @@ | |||
| // | |||
| // Subcomponent.swift | |||
| // Component.swift | |||
There was a problem hiding this comment.
Rename this file to Component.swift
CleanseTests/CycleTests.swift
Outdated
| _ = try ComponentFactory.of(BadComponent) | ||
| XCTFail("Should not succeed") | ||
| } catch let e { | ||
|
|
There was a problem hiding this comment.
Is there an easy way to assert error messages?
There was a problem hiding this comment.
Yeah, I need to copy what we're doing in ErrorTest... which is what's going to happen before merging
|
|
fixes #5
* Simplified DSL (configure function) * Binders now have scopes. One can only scope things for the binder that is scoping it * Scope has to be passed along to modules from component * Language can enforce scoping now! this means validations can be removed * Removed "Scoped" protocol. This created ambiguity
Bring back TaggedProvider#asProvider
change some access levels to public to prevent optimization out
Combines the 2 files into a main.swift and runs swift on it. The file overwrites the existing files.
Holmes/clean it up
Updates the code to Swift 3.1, and the bindings to the latest in Cleanse.
Fix CleanseGithubBrowser
Leave a note that docs are out of date
Swift 3 Support: code & examples Docs coming soon...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes Components constructed via ComponentFactory now
WIP separating validation logic from Graph. Sub-components are now easily validatable
cc @holmes @sebastianv1