Enable unit tests and TouchIDTest to run successfully on Xcode 8 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because I upgraded the Touch ID test app to use Swift 3. Going to bump Travis CI to use Xcode 8 instead of 7. No need for a major version bump because the library still works on Xcode 7. |
dfed
force-pushed
the
dfed/xcode_8_ci
branch
2 times, most recently
from
8a872c3
to
7a4c593
Compare
dfed
force-pushed
the
dfed/xcode_8_ci
branch
3 times, most recently
from
73ddad0
to
f582b4f
Compare
dfed
force-pushed
the
dfed/xcode_8_ci
branch
2 times, most recently
from
f63cfd3
to
ea3caf9
Compare
|
@brianpartridge you already GORM'd #103, but mind giving this guy a quick once-over as well? |
|
LGTM |
brianpartridge
approved these changes
Jan 17, 2017
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows unit tests to run on Xcode 8. iOS unit tests now run in a host app. Mac unit tests now ignore tests that require entitlements (e.g. SecureEnclave tests). Addresses #93.
Note: this PR is built on top of #97. It will need to be merged first.