Add Xcode 8 troubleshooting to Debugging steps #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfed
force-pushed
the
federman/update_readme_96
branch
from
5d6f6d9
to
7ec74d4
Compare
dfed
force-pushed
the
federman/update_readme_96
branch
from
2a75c49
to
5a05bd9
Compare
|
ping :) |
kwigginton
reviewed
Jan 16, 2017
| @@ -118,6 +118,7 @@ Valet guarantees it will never fail to write to or read from the keychain unless | |||
| 3. Using `VALSecureEnclaveValet` on an iOS device that doesn't have a Secure Enclave. The Secure Enclave was introduced with the [A7 chip](https://www.apple.com/business/docs/iOS_Security_Guide.pdf), which [first appeared](https://en.wikipedia.org/wiki/Apple_A7#Products_that_include_the_Apple_A7) in the iPhone 5S, iPad Air, and iPad Mini 2. | |||
| 4. Running your app in DEBUG from Xcode. Xcode sometimes does not properly sign your app, which causes a [failure to access keychain](https://github.com/square/Valet/issues/10#issuecomment-114408954) due to entitlements. If you run into this issue, just hit Run in Xcode again. This signing issue will not occur in properly signed (not DEBUG) builds. | |||
| 5. Running your app on device or in the simulator with a debugger attached may also [cause an entitlements error](https://forums.developer.apple.com/thread/4743) to be returned when reading from or writing to the keychain. To work around this issue on device, run the app without the debugger attached. After running once without the debugger attached the keychain will usually behave properly for a few runs with the debugger attached before the process needs to be repeated. | |||
| 6. Running your app without the application-identifier entitlement. Xcode 8 introduced a requirement that all schemes must be signed with the application-identifier entitlement to access the keychain. | |||
There was a problem hiding this comment.
Per our discussions, I think this needs to specify the workaround for tests targets where you cannot add the entitlement whatsoever, and that adding a tests target host-app allows testing to work as necessary.
|
Have a verbal LGTM from @hailstorm350. Merging when green. |
…nit tests successfully on Xcode 8
dfed
force-pushed
the
federman/update_readme_96
branch
from
40dee1f
to
2e41776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @EricMuller22 @timdonnelly
Resolves #96