Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the special case of injecting a Provider<Lazy<Type>> properly. #361

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Handle the special case of injecting a Provider<Lazy<Type>> properly. #361

merged 1 commit into from
Aug 27, 2021

Conversation

vRallev
Copy link
Collaborator

@vRallev vRallev commented Aug 27, 2021

Fixes #344

vRallev
vRallev commented Aug 27, 2021
View reviewed changes
...er/src/test/java/com/squareup/anvil/compiler/dagger/InjectConstructorFactoryGeneratorTest.kt
@Test
@Ignore("This test is broken with Dagger as well.")
// Notice in the get() function Dagger creates a Lazy of a Provider of Provider instead of a
// Lazy of a Provider.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oopsie

@vRallev vRallev merged commit 43c856d into main Aug 27, 2021
@vRallev vRallev deleted the ralf/lazy-provider branch August 27, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xMatthewGroves 0xMatthewGroves 0xMatthewGroves approved these changes

@christiandeange christiandeange Awaiting requested review from christiandeange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider<Lazy<...>> is not handled correctly
2 participants
@vRallev @0xMatthewGroves