Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Incremental compilation via constructor parameter change. #755

Closed

Conversation

Laimiux
Copy link

@Laimiux Laimiux commented Oct 6, 2023

Attempting to fix #754, it would be good for someone with a better understanding of compiler plugins to take a look at this. I was able to test various scenarios successfully, but they might not be exhaustive.

@CLAassistant
Copy link

CLAassistant commented Oct 6, 2023

CLA assistant check
All committers have signed the CLA.

@Laimiux Laimiux force-pushed the laimonas/fix-incremental-code-gen-issue branch from 4e62e5d to 1e541b1 Compare October 6, 2023 22:32
@midery
Copy link

midery commented Oct 27, 2023

@Laimiux Thanks for taking care of the fix! I also ran it in the sample project and on my own project with different scenarios, and it indeed fixes the problematic behaviour.

@JoelWilcox could you please share the vision of the Anvil team on this fix? I see that it can solve the problem, but as @Laimiux said, it may not be applicable for all the use-cases in complex projects.

@JoelWilcox
Copy link
Member

@Laimiux Thanks for taking care of the fix! I also ran it in the sample project and on my own project with different scenarios, and it indeed fixes the problematic behaviour.

➕ Thanks for taking a stab at this @Laimiux!

@JoelWilcox could you please share the vision of the Anvil team on this fix? I see that it can solve the problem, but as @Laimiux said, it may not be applicable for all the use-cases in complex projects.

Due to the nature of the incremental compilation issues and how easy it is for regressions to happen in new areas even if we fix some cases, we're making sure we get appropriate integration test coverage in place before moving forward with related fixes. @RBusarow is currently working on that and applying the fix described in #693 (comment).

@JoelWilcox
Copy link
Member

JoelWilcox commented Feb 6, 2024

Thanks again for the PR; closing now in favor of #836

@JoelWilcox JoelWilcox closed this Feb 6, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental compilation breaks when modifying constructor properties
4 participants