This repository has been archived by the owner on Mar 2, 2023. It is now read-only.
Implement backend.ChainHeight() #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. You missed rename of |
mbyczkowski
reviewed
Oct 15, 2018
backend/recorder_backend.go
Outdated
| @@ -84,6 +84,10 @@ func (rb *RecorderBackend) Finish() { | |||
| } | |||
| } | |||
|
|
|||
| func (rb *RecorderBackend) ChainHeight() uint32 { | |||
| return 0 | |||
There was a problem hiding this comment.
this could be rb.backend.ChainHeight()
mbyczkowski
reviewed
Oct 15, 2018
backend/fixture_backend.go
Outdated
| @@ -85,6 +85,10 @@ func (b *FixtureBackend) Finish() { | |||
| close(b.doneCh) | |||
| } | |||
|
|
|||
| func (b *FixtureBackend) ChainHeight() uint32 { | |||
| return 0 | |||
There was a problem hiding this comment.
if we stored the metadata in the fixture file, we could return that.
alokmenghrajani
force-pushed
the
alok/current_height
branch
2 times, most recently
from
aa0ce2b
to
d6ff3b8
Compare
The code already existed for Btcd, but the Electrum backend needed some work. Exposing the chain height is useful for two reasons: 1. it enables us to make the --block-height parameter optional and default to current height - 6. 2. it enables binary searching for a block given a timestamp.
mbyczkowski
force-pushed
the
alok/current_height
branch
from
d6ff3b8
to
de351c2
Compare
Pull Request Test Coverage Report for Build 154
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code already existed for Btcd, but the Electrum backend needed some
work.
Exposing the chain height is useful for two reasons:
default to current height - 6.