Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of the format list in the connect command #260

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Remove use of the format list in the connect command #260

merged 1 commit into from
Feb 24, 2022

Conversation

jdtw
Copy link
Contributor

@jdtw jdtw commented Feb 24, 2022 •
edited

Format isn't used in the connect flow (only dump). This leads to a panic:

❯ ./certigo connect google.com -l
panic: runtime error: slice bounds out of range [:1] with capacity 0

goroutine 1 [running]:
github.com/square/certigo/cli.Run({0xc000020090, 0x3, 0x3}, {0x14c3378, 0xc000010200})
        /Users/jwood/Development/certigo/cli/cli.go:186 +0x187c
main.main()
        /Users/jwood/Development/certigo/main.go:27 +0x89

@jdtw jdtw requested review from a team, mweissbacher, stfinney and wtmcc February 24, 2022 20:35
isemaya-square
isemaya-square approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@isemaya-square isemaya-square left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@jdtw jdtw merged commit f8a8c1f into master Feb 24, 2022
@jdtw jdtw deleted the jwood/fix-panic branch February 24, 2022 20:40
jdtw added a commit to jdtw/certigo that referenced this pull request Jul 25, 2022
@jdtw
Merge branch 'master' into jdtw/proxy-command
21ba4e4 
* master: (21 commits)
  Update README.md
  Unconditionally add forward slash in OCSP GET requests (square#282)
  Use Go generate instead of a makefile (square#279)
  Bump github.com/stretchr/testify from 1.7.5 to 1.8.0
  Add support for printing SCTs (square#277)
  Update Go version to 1.18 (square#276)
  Update to 1.16 (square#275)
  Fix OCSP checking (square#274)
  Bump github.com/stretchr/testify from 1.7.2 to 1.7.5
  Update go command to install certigo (square#270)
  Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
  Upgrade yaml.v3 version (square#266)
  Allow any ciphersuite in TestConnect (square#268)
  Fix TestConnect on macOS (square#265)
  Bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (square#262)
  Bump version string to 1.15.1 (square#263)
  Remove use of the format list in the connect command (square#260)
  Add --leaf flag to view the first cert only, including for json and pem
  Set certs explicitly (square#259)
  Upgrade /x/crypto dependency (square#257)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isemaya-square isemaya-square isemaya-square approved these changes

@mweissbacher mweissbacher Awaiting requested review from mweissbacher

@stfinney stfinney Awaiting requested review from stfinney

@wtmcc wtmcc Awaiting requested review from wtmcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jdtw @isemaya-square