Fix OCSP checking #274
Merged
Fix OCSP checking #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdtw
commented
Jun 28, 2022
| @@ -32,7 +32,7 @@ import ( | |||
| ) | |||
|
|
|||
| var ( | |||
| skippedRevocationCheck = errors.New("skipped revocation check") | |||
| errSkippedRevocationCheck = errors.New("skipped revocation check") | |||
There was a problem hiding this comment.
fixes the lint about error naming while I'm in the file...
sq-smits
approved these changes
Jun 28, 2022
jdtw
added a commit
to jdtw/certigo
that referenced
this pull request
Jul 25, 2022
* master: (21 commits) Update README.md Unconditionally add forward slash in OCSP GET requests (square#282) Use Go generate instead of a makefile (square#279) Bump github.com/stretchr/testify from 1.7.5 to 1.8.0 Add support for printing SCTs (square#277) Update Go version to 1.18 (square#276) Update to 1.16 (square#275) Fix OCSP checking (square#274) Bump github.com/stretchr/testify from 1.7.2 to 1.7.5 Update go command to install certigo (square#270) Bump github.com/stretchr/testify from 1.7.1 to 1.7.2 Upgrade yaml.v3 version (square#266) Allow any ciphersuite in TestConnect (square#268) Fix TestConnect on macOS (square#265) Bump github.com/stretchr/testify from 1.7.0 to 1.7.1 (square#262) Bump version string to 1.15.1 (square#263) Remove use of the format list in the connect command (square#260) Add --leaf flag to view the first cert only, including for json and pem Set certs explicitly (square#259) Upgrade /x/crypto dependency (square#257) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272. The root of the problem is that we're asking the wrong OCSP servers. The current code does something like:
The main problem is that
OCSPServeris the URI of the OCSP server for that certificate, and by askingissuer.OCSPServeraboutleaf, we're requesting OCSP responses from the wrong server. We should be checkingleaf.OCSPServerin this example instead ofissuer.OCSPServer.The second problem is that the loop makes no sense. One would not expect any OCSP server in a given chain to be authoritative for a given leaf.
If you do certigo connect google.com, you'll see
The "unauthorized" means the OCSP server we asked doesn't know anything about the cert we asked about.