Fix view state persistence #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| container = (PathContainerView) findViewById(R.id.container); | ||
| containerAsBackTarget = (HandlesBack) container; | ||
| flowSupport = ActivityFlowSupport.onCreate(nonConfig, getIntent(), savedInstanceState, parceler, |
There was a problem hiding this comment.
Should add javadoc to ActivityFlowSupport#onCreate that this should be called after setContentView.
|
LGTM |
Thanks to Aleksey Malevaniy for catching these problems and demonstrating fixes. This change fixes two problems with view state persistence in ActivityFlowSupport: 1. It was just throwing view state away when building the Parcelable to save in the Bundle. The fix is to move filtering into Backstack itself, so that it can build a Parcelable that includes view state. 2. It wasn (re)constructing the view hierarchy for the first time in onResume(), which is after restoreHierarchyState() is called. View state was therefore not getting properly restored. The fix is to rebuild the view hierarchy in onCreate(), so that it's there in time for restoreHierarchyState().
loganj
force-pushed
the
loganj/view_state
branch
from
2e1fb31
to
c51218b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Aleksey Malevaniy for catching these problems and
demonstrating fixes.
This change fixes two problems with view state persistence in
ActivityFlowSupport:
save in the Bundle. The fix is to move filtering into Backstack itself,
so that it can build a Parcelable that includes view state.
onResume(), which is after restoreHierarchyState() is called. View
state was therefore not getting properly restored. The fix is to rebuild
the view hierarchy in onCreate(), so that it's there in time for
restoreHierarchyState().