Backstack entry's view state is never saved on rotation

[almozavr]

Precondition

According so sample, in case of screen rotation NonConfigurationInstance is used to save backstack

Problem

Backstack entry's viewState is not saved on ration, so when recreating flow with backstack, topmost entry doesn't have what to restore and views data (such as text for EditText) is lost.

[almozavr]

↑ Here is an example of solving issue for rotation only situation (when backstack stays the same instance).

[almozavr]

Please, could someone tell me why ActivityFlowSupport#getBackstackToSave(Backstack backstack) creates a copy of backstack with dropped viewstates? This is key to problem of overall persistance (e.g. activity was destroyed and user goes back to app again)

[almozavr]

↑ Fix for graceful backstack's viewstates persistance. Don't know if it's dirty for current code model, so punish hard, ready to take it further

[rjrjr]

PTAL at https://github.com/square/flow/pull/72/files

[almozavr]

@rjrjr Sorry, I found no solution of this problem in #72, because:

• ActivityFlowSupport#getBackstackToSave still ignores current viewstates of backstack entries;
• flow support doesn't do snapshot of viewstate of current path before getBackstackToSave called, so I suppose e.g. EditText text will still be lost on rotation.

[rjrjr]

Yup, rotation is definitely broken. Still not sure that this is the way to fix it though, looking.

[loganj]

Yep. Thanks for the catch, and for the patches. I've made some slightly different fixes in #75.

[almozavr]

Thanks, looks great.

On Fri, Apr 3, 2015 at 12:24 AM Logan Johnson notifications@github.com
wrote:

Closed #67 #67.

—
Reply to this email directly or view it on GitHub
#67 (comment).