-
Notifications
You must be signed in to change notification settings - Fork 270
Conversation
6e844b4
to
07268a3
Compare
@csstaub Could you please review this PR? If the mention is wrong, I'm sorry. I know that v3 repository already exists. |
I can review this, but I don't have permissions on this repository anymore @shnmorimoto so it's not possible for me to do a release with this. |
If you raise this on the v3 repo I can merge it there and release it as a minor version |
@csstaub Thanks for replying! I raised PR to v3 repository. |
@mbyczkowski If the mention is wrong, I apologize. This fix already had been merged on v3 repository. |
@mbyczkowski Sorry for bothering you. |
Bump - I can confirm that we're also running into this issue on our team using v2. Would love to see this merged, especially since v2 is still considered the stable version |
Ditto, it is stopping the use of this package. |
Is this still an issue with v3: https://github.com/go-jose/go-jose ? |
The square/go-jose repo is the v2 version, v3 development moved over to go-jose/go-jose |
Looks like v3 will solve it but noticed that it is a dependency of |
There's a stable release for v3 now so I'd recommend to switch and submit new changes there. I don't have access to this repo anymore since I left Square. I'll see if we can update the README here. |
Related Issue
fixed #286
Description