Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix Allow multiple audiences #369

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions jwt/validation.go
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,16 @@ func (c Claims) ValidateWithLeeway(e Expected, leeway time.Duration) error {
}

if len(e.Audience) != 0 {
flag := false
for _, v := range e.Audience {
if !c.Audience.Contains(v) {
return ErrInvalidAudience
if c.Audience.Contains(v) {
flag = true
break
}
}
if !flag {
return ErrInvalidAudience
}
}

if !e.Time.IsZero() {
Expand Down
11 changes: 11 additions & 0 deletions jwt/validation_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,17 @@ func TestFieldsMatch(t *testing.T) {
assert.NoError(t, c.Validate(v))
}

claimsWithSingleAudience := Claims{
Issuer: "issuer",
Subject: "subject",
Audience: []string{"a1"},
ID: "42",
}

for _, v := range valid {
assert.NoError(t, claimsWithSingleAudience.Validate(v))
}

invalid := []struct {
Expected Expected
Error error
Expand Down