Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor typos fixed #19

Merged
merged 2 commits into from
Jun 13, 2016
Merged

minor typos fixed #19

merged 2 commits into from
Jun 13, 2016

Conversation

twolfe2
Copy link
Contributor

@twolfe2 twolfe2 commented Jun 13, 2016

No description provided.

zachmargolis
zachmargolis reviewed Jun 13, 2016
View reviewed changes
z03-data-binding.md
@@ -309,7 +308,7 @@ nextrects.enter().append('rect'); // adds one element

## Transitions `selection.transition()`

The key function also important in case parts of our objects change -- if we
The key function <isindex></isindex> also important in case parts of our objects change -- if we
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the <isindex> tag? Is this supposed to be: function is also important ?

@zachmargolis
Copy link
Collaborator

Thanks for this! Please sign Square's Individual Contributor License Agreement so we can accept your changes, then let us know!

@twolfe2
Copy link
Contributor Author

twolfe2 commented Jun 13, 2016

The agreement has been filled out.

Best,
Thomas​

On Sun, Jun 12, 2016 at 7:08 PM, Zach Margolis notifications@github.com
wrote:

Thanks for this! Please sign Square's Individual Contributor License
Agreement
https://spreadsheets.google.com/spreadsheet/viewform?formkey=dDViT2xzUHAwRkI3X3k5Z0lQM091OGc6MQ&ndplr=1
so we can accept your changes, then let us know!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#19 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANTbM9OIq_agvTCP3lnC8hWCrBstv_Bzks5qLLuhgaJpZM4Iz67a
.

@zachmargolis
Copy link
Collaborator

Ok, great, thanks! Can you fix the <isindex> tag before we merge?

@twolfe2
Copy link
Contributor Author

twolfe2 commented Jun 13, 2016

Fixed

@zachmargolis
Copy link
Collaborator

Great! Thanks for your help!

@zachmargolis zachmargolis merged commit 32ce189 into square:master Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twolfe2 @zachmargolis