There is a missing symbol "?" in [$T for Types] - [Import static] #537
Conversation
| @@ -320,7 +320,7 @@ MethodSpec beyond = MethodSpec.methodBuilder("beyond") | |||
| .addStatement("result.add($T.createNimbus(\"2001\"))", hoverboard) | |||
| .addStatement("result.add($T.createNimbus($T.THUNDERBOLT))", hoverboard, namedBoards) | |||
| .addStatement("$T.sort(result)", Collections.class) | |||
| .addStatement("return result.isEmpty() $T.emptyList() : result", Collections.class) | |||
| .addStatement("return result.isEmpty() ? $T.emptyList() : result", Collections.class) | |||
There was a problem hiding this comment.
More importantly, I think this isEmpty check is useless (technically, in the generated code it definitely is; but it doesn't even add anything to the example either). I suggest replacing the line with:
.addStatement("return result")There was a problem hiding this comment.
This is an example for using Import static.
I think $T.emptyList() is more importantly.
There was a problem hiding this comment.
There's already the $T.sort(result) above.
There was a problem hiding this comment.
Now I tend to agree with @mcxtzhang ... if only Collections.sort was to be imported, it'd be better to use a single static type import instead of the * version.
The additional value is to demonstrate the usage of .addStaticImport(Collections.class, "*") with a Class<?> instance.
There was a problem hiding this comment.
Now, only an Enum constant overload demo is missing... 😉
|
@mcxtzhang can you please insert two more |
mcxtzhang
changed the title
mcxtzhang
changed the title
? in [$T for Types] - [Import static]
mcxtzhang
changed the title
? in [$T for Types] - [Import static]
|
I've inserted them. |
|
Merci! |
There is a missing symbol "?" in [$T for Types] - [Import static]