Support multi-member annotations. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,6 +57,16 @@ public Appendable write(Appendable appendable, Context context) throws IOExcepti | |||
| appendable.append(onlyEntry.getKey()).append(" = "); | |||
| } | |||
| onlyEntry.getValue().write(appendable, context); | |||
| } else { | |||
| boolean first = true; | |||
There was a problem hiding this comment.
As a simpler alternative:
String sep = "";
for (Entry<String, Writable> entry : memberMap.entrySet()) {
appendable.append(sep).append(entry.getKey()).append(" = ");
entry.getValue().write(appendable, context);
sep = ", ";
}
JakeWharton
force-pushed
the
jw/multimember-annotation
branch
from
498c53a
to
5b0ae5f
Compare
| import java.util.Set; | ||
|
|
||
| /** A context which always returns fully-qualified type names. */ | ||
| final class EmptyContext implements Writable.Context { |
There was a problem hiding this comment.
There's an equivalent such context in Writeables; maybe there can be reuse here?
There was a problem hiding this comment.
It works for this case, but I don't think it will work for a larger-scope testing strategy where we want to verify the actual output due to its createSubcontext behavior (throwing exception).
There was a problem hiding this comment.
What I meant is EmptyContext (with its createSubcontext() could be moved out of src/test and used in Writeables.
There was a problem hiding this comment.
Ah, I see. Yeah you're right. For now I'll switch. When we start testing more we'll know what to change.
JakeWharton
force-pushed
the
jw/multimember-annotation
branch
from
5b0ae5f
to
1bf20dd
Compare
swankjesse
added a commit
that referenced
this pull request
Dec 2, 2014
Support multi-member annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76.