Support generating a single import for overloaded MemberNames #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MemberName imports were modeled after TypeName imports, where an import can only represent a single fully-qualified name. However with MemberNames, a single import can represent multiple overloaded members that share a fully-qualified name. While overloaded members can be represented with a single MemberName, we distinguish between extension and non-extension members, and their MemberNames are not equal. We'll currently try to generate import aliases in this case, which is incorrect, and actually impossible, since they have the exact same fully-qualified name (see #1907). This change handles this scenario and adds support for having a single import generated for multiple MemberNames.
JakeWharton
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1907.
MemberName imports were modeled after TypeName imports, where an import can only represent a single fully-qualified name. However with MemberNames, a single import can represent multiple overloaded members that share a fully-qualified name. While overloaded members can be represented with a single MemberName, we distinguish between extension and non-extension members, and their MemberNames are not equal. We'll currently try to generate import aliases in this case, which is incorrect, and actually impossible, since they have the exact same fully-qualified name (see #1907). This change handles this scenario and adds support for having a single import generated for multiple MemberNames.
docs/changelog.mdhas been updated if applicable.