Add support for empty setters #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Nov 1, 2018
JakeWharton
approved these changes
Nov 1, 2018
| @@ -44,6 +44,7 @@ class FunSpec private constructor(builder: Builder) { | |||
| val delegateConstructor = builder.delegateConstructor | |||
| val delegateConstructorArguments = builder.delegateConstructorArguments.toImmutableList() | |||
| val body = builder.body.build() | |||
| val isEmptySetter = name == SETTER && parameters.isEmpty() | |||
cwwwu
force-pushed
the
wallace/20181101_empty_setter
branch
from
cc2be8d
to
5ee19f5
Compare
|
|
||
| init { | ||
| require(body.isEmpty() || ABSTRACT !in builder.modifiers) { | ||
| "abstract function ${builder.name} cannot have code" | ||
| } | ||
| require(name != SETTER || parameters.size == 1) { | ||
| require(name != SETTER || parameters.size <= 1) { | ||
| "$name must have exactly one parameter" |
There was a problem hiding this comment.
Can we change the message to reflect the newer condition?
cwwwu
force-pushed
the
wallace/20181101_empty_setter
branch
from
5ee19f5
to
8752e17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494