Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move activities into their own leakcanary-identified process #706

Closed
JakeWharton opened this issue Feb 24, 2017 · 1 comment
Closed

Move activities into their own leakcanary-identified process #706

JakeWharton opened this issue Feb 24, 2017 · 1 comment

Comments

@JakeWharton
Copy link
Member

JakeWharton commented Feb 24, 2017

The leak and permission activities have their own task affinity but still reside in the host app's process. This means they're subject to whatever happens in the Application.onCreate unlike the leak analysis service. In our case, we set up a violently punishing strict mode which the leak display activity violates (and thus crashes).

Instead of adding a bunch of try/finally blocks to disable strict mode around the harmless disk reads on the main thread in the leak display activity, it would be better if these activities had their own process which was identified as being leak canary-owned by the LeakCanary.isInWhateverProcess method. It doesn't have to be the same process as the analysis service, just a non-default one that in turn skips the normal application creation process just like the service would.

@JakeWharton
Copy link
Member Author

And I can do this if it seems like an acceptable change.

@jrodbx jrodbx added this to the 1.6 milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants