Move leak canary UI into leak process. #711
Conversation
This ensures that isInAnalyzerProcess returns true for these elements thus preventing the normal Application behavior from affecting these components.
JakeWharton
force-pushed
the
jw/2017-02-27/process
branch
from
8c1a131
to
948d3ef
Compare
| @@ -49,6 +51,7 @@ | |||
| <activity | |||
| android:theme="@style/leak_canary_Theme.Transparent" | |||
| android:name=".internal.RequestStoragePermissionActivity" | |||
| android:process=":leakcanary" | |||
There was a problem hiding this comment.
Being mindful of the current OOM issues we've been seeing, it might be better to move these to yet another process. WDYT?
There was a problem hiding this comment.
I initially was going to do that but it requires changes to the isInLeakProcess method. I'm sure it's not that difficult of a change to make though.
There was a problem hiding this comment.
Thinking about this again, I'm not sure this is worth the effort. These two activities and services aren't large, but also they aren't going to be created concurrently while the leak analysis is occurring.
There was a problem hiding this comment.
Profiled leakcanary-sample in Android Studio 2.4 preview 7 and launched using RequestStoragePermissionActivity using adb shell am. Turns out that while it eats some heap space in the com.example.leakcanary:leakcanary process, it's not as much as I thought.
|
LGTM |
This ensures that isInAnalyzerProcess returns true for these elements thus preventing the normal Application behavior from affecting these components.
Closes #706.