Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 512x512 icon (Issue #9) #36

Merged
merged 2 commits into from
May 15, 2015
Merged

New 512x512 icon (Issue #9) #36

merged 2 commits into from
May 15, 2015

Conversation

romainguy
Copy link
Contributor

This icon was entirely recreated as a vector asset in Affinity
Designer. I can check in the source Affinity Designer or other vector
variants as needed (PDF, SVG, etc.)

This icon was entirely recreated as a vector asset in Affinity
Designer. I can check in the source Affinity Designer or other vector
variants as needed (PDF, SVG, etc.)
@pyricau
Copy link
Member

pyricau commented May 12, 2015

Yes, sources in the assets folder would be great. Both the original source (Affinity Designer) and SVG.

We'll need to regenerate the app icon and the notification icon, which I've created with the online assets studio, based on assets/source_icon.png (even the 512px is based on it).

assets/source_icon.png has weird artifacts:

screen shot 2015-05-12 at 8 24 16 am

If you could regenerate it without those, and actually if you could generate a bigger version of it (1024?), that would be perfect.

@romainguy
Copy link
Contributor Author

I'll add the afdesign and SVG files to assets/ and I'll regenerate
source_icon in 1024. I'll let you regenerate the other icons from Asset
Studio as I'm not sure which settings you used exactly.

The artifacts you see in source_icon are interesting; they are not present
in my copy of the files. I don't see the artifact in my local copy of the
repository, nor in the original Affinity file, nor when I export it again.
I wonder if the file is getting recompressed somehow by a Web UI you might
be using?

Anyway, I'll double check for artifacts when I re-export in 1024px.

On Tue, May 12, 2015 at 8:27 AM, Pierre-Yves Ricau <notifications@github.com

wrote:

Yes, sources in the assets folder would be great. Both the original source
(Affinity Designer) and SVG.

We'll need to regenerate the app icon and the notification icon, which
I've created with the online assets studio, based on
assets/source_icon.png (even the 512px is based on it).

assets/source_icon.png has weird artifacts:

[image: screen shot 2015-05-12 at 8 24 16 am]
https://cloud.githubusercontent.com/assets/557033/7591054/71b8d3d4-f880-11e4-95a0-9c741f13d9db.png

If you could regenerate it without those, and actually if you could
generate a bigger version of it (1024?), that would be perfect.


Reply to this email directly or view it on GitHub
#36 (comment).

Romain Guy romainguy@curious-creature.com
http://www.curious-creature.com

@pyricau
Copy link
Member

pyricau commented May 12, 2015

Weird. That's the raw file according to GitHub: https://raw.githubusercontent.com/romainguy/leakcanary/rg/icons/assets/source_icon.png

Add SVG asset
Add original Affinity Designer asset
Add 1024x1024 icon
pyricau added a commit that referenced this pull request May 15, 2015
@pyricau pyricau merged commit 53c24f0 into square:master May 15, 2015
Yky pushed a commit to Yky/leakcanary that referenced this pull request Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants