build: convert .cjs to .js #547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos-square
force-pushed
the
remove-cjs
branch
from
6ea0eaa
to
7b340c3
Compare
stephanos-square
changed the title
stephanos-square
force-pushed
the
remove-cjs
branch
6 times, most recently
from
c609e8c
to
e16f3c3
Compare
stephanos-square
force-pushed
the
remove-cjs
branch
from
e16f3c3
to
67df73e
Compare
|
This PR has been automatically closed because it hasn't received any activity in over 3 months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the problem this PR addresses
The code was using a mix of
.js("import") and.cjs("require") files. This makes it impossible to use from Vite/Vitess and harder to migrate from CommonJS to ESM in the near future.Describe the changes in this PR
This converts all
.cjsfiles to.js. Most of the change involves just renaming the files and changingrequiretoimportandmodule.exportstoexport default. But the.postcssrc.jsfile required an extra build step. That's because it's not capable of dealing withimports (I tried using.mjsand.ts- which both failed). Now the code it needs is pre-bundled so it can berequired.Using the "Compare Directories" feature in IntelliJ to compare the build output before and after the change, we can see that the only files that changed are:
components/Theme/script.jsutils/maker-colors.jsTaking a closer look at these two, it appears that this change caused Webpack to bundle these two files slightly differently. But the content appears to effectively be the same.