With context and better sharing for memoization #310

Nathan-Fenner · 2016-06-30T19:50:56Z

Add a WithAdditionalConstraint(predicate.Predicate) method to EvaluationContext that plays nice with memoization.

Also, add a memoizationMap to the EvaluationContext which can be used to look up already-existing memoizations within the same query, which makes the following query much more efficient, by performing the fetch for cpu only once instead of twice:

transform.timeshift(cpu, -1w) + transform.timeshift(cpu, -1)
from -30m to now

drcapulet · 2016-07-01T23:53:50Z

function/memoize.go

+	m.Lock()
+	defer m.Unlock()
+	_, ok := m.Map[i]
+	if !ok {


You can just do if _, ok := m.Map[i]; !ok {

Nathan-Fenner added the for 1.0 label Jun 30, 2016

with context and better sharing for memoization

0f0f1bc

Nathan-Fenner mentioned this pull request Jun 30, 2016

DO NOT MERGE - Adding WithPredicate #289

Closed

Nathan-Fenner added the enhancement label Jun 30, 2016

nathanf and others added 2 commits June 30, 2016 13:40

add test for sharing among identical subcontexts

8c39d72

Update memoize.go

1f58c30

drcapulet self-assigned this Jul 1, 2016

drcapulet reviewed Jul 1, 2016
View reviewed changes

function/memoize.go

m.Lock()

defer m.Unlock()

_, ok := m.Map[i]

if !ok {

Copy link

Collaborator

drcapulet Jul 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just do if _, ok := m.Map[i]; !ok {

condensify if statement

53792a1

drcapulet merged commit 0ecffaa into master Jul 1, 2016

drcapulet deleted the nathan-fenner-with-context branch July 1, 2016 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

With context and better sharing for memoization #310

With context and better sharing for memoization #310

Nathan-Fenner commented Jun 30, 2016 •

edited

Loading

drcapulet Jul 1, 2016

With context and better sharing for memoization #310

With context and better sharing for memoization #310

Conversation

Nathan-Fenner commented Jun 30, 2016 • edited Loading

drcapulet Jul 1, 2016

Choose a reason for hiding this comment

Nathan-Fenner commented Jun 30, 2016 •

edited

Loading