Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No, don't takeView in onFinishInflate #175

Merged
merged 1 commit into from
Sep 18, 2015
+2 −7
Merged

No, don't takeView in onFinishInflate #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mortar-sample/src/main/java/com/example/mortar/screen/FramePathContainerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ protected FramePathContainerView(Context context, AttributeSet attrs, PathContai
return this;
}

@Override protected void onFinishInflate() {
super.onFinishInflate();
}

@Override public void dispatch(Flow.Traversal traversal, final Flow.TraversalCallback callback) {
disabled = true;
container.executeTraversal(this, traversal, new Flow.TraversalCallback() {
Expand Down
5 changes: 2 additions & 3 deletions mortar/src/main/java/mortar/Presenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ public abstract class Presenter<V> {
};

/**
* Called to give this presenter control of a view, ideally from {@link
* android.view.View#onFinishInflate}. If a view is to be re-used, make an additional call from
* {@link android.view.View#onAttachedToWindow()}. (Redundant calls will safely no-op.) Sets the
* Called to give this presenter control of a view, typically from
* {@link android.view.View#onAttachedToWindow()}. Sets the
* view that will be returned from {@link #getView()}.
* <p/>
* This presenter will be immediately {@link BundleService#register registered}
Expand Down