No, don't takeView in onFinishInflate #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,8 +51,7 @@ | |||
| }; | |||
|
|
|||
| /** | |||
| * Called to give this presenter control of a view, ideally from {@link | |||
| * android.view.View#onFinishInflate}. If a view is to be re-used, make an additional call from | |||
| * Called to give this presenter control of a view, typically from | |||
| * {@link android.view.View#onAttachedToWindow()}. (Redundant calls will safely no-op.) Sets the | |||
There was a problem hiding this comment.
You should rewrite (or drop) the redundant note.
|
LGTM |
rjrjr
force-pushed
the
ray/stale-inflate-docs
branch
from
d4c2264
to
0737c17
Compare
Note that none of the sample code does.
rjrjr
force-pushed
the
ray/stale-inflate-docs
branch
from
0737c17
to
e20011e
Compare
rjrjr
added a commit
that referenced
this pull request
Sep 18, 2015
No, don't takeView in onFinishInflate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that none of the sample code does.