Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better behavior converting malformed percent escapes #2116

Closed
swankjesse opened this issue Dec 16, 2015 · 0 comments
Closed

Better behavior converting malformed percent escapes #2116

swankjesse opened this issue Dec 16, 2015 · 0 comments
Labels
bug Bug in existing code
Milestone
3.0

Comments

@swankjesse
Copy link
Member

Rather than throwing an exception when converting http://host/%xx to a java.net.URI, OkHttp should just convert it to http://host/%25xx which is a reasonable alternative.
@swankjesse swankjesse added the bug Bug in existing code label Dec 16, 2015
@swankjesse swankjesse added this to the 3.0 milestone Dec 16, 2015
swankjesse added a commit that referenced this issue Dec 23, 2015
@swankjesse
Never throw converting an HttpUrl to a java.net.URI.
d77edcc 
Just do arbitrary amounts of transformation. Sigh.

Closes #2116
@swankjesse swankjesse mentioned this issue Dec 23, 2015
Merged
amartinz pushed a commit to NamelessRom/android_external_okhttp that referenced this issue Jun 30, 2016
@nfuller @15characterlimi
Reapply an upstream OkHttp change to Android for HttpUrl
637ebbf 
This was originally commited to AOSP as 3281dee
The upstream commit was part of OkHttp 3.0 but not 2.7.5.

Previous commit message:

Manually reapplied change from upstream to address HttpUrl encoding issues.
This change did not apply cleanly. Upstream FormEncodingBuilder has
been refactored. Equivalent changes have been made.

Upstream details:
Comment:
Never throw converting an HttpUrl to a java.net.URI.

Just do arbitrary amounts of transformation. Sigh.

Closes square/okhttp#2116
SHA: d77edcc8905148f18a691be180c4f8f366a5ee1b

Change-Id: I588e8906c22d2db565e4582a454fa5894071feae
cm-gerrit pushed a commit to CyanogenMod/android_external_okhttp that referenced this issue Aug 24, 2016
@nfuller
Reapply an upstream OkHttp change to Android for HttpUrl
4c52173 
Manually reapplied change from upstream to address HttpUrl encoding issues.
This change did not apply cleanly. Upstream FormEncodingBuilder has
been refactored. Equivalent changes have been made.

Upstream details:
Comment:
Never throw converting an HttpUrl to a java.net.URI.

Just do arbitrary amounts of transformation. Sigh.

Closes square/okhttp#2116
SHA: d77edcc8905148f18a691be180c4f8f366a5ee1b

Bug: 27590872
Change-Id: Ia12df5dc95c1681c67552b2c7725393508f52c0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug in existing code
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@swankjesse