Add a web socket call concept for connecting. #1182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw/websocket-call
branch
2 times, most recently
from
9aa7441
to
60dbab2
Compare
| import okio.ByteString; | ||
| import okio.Okio; | ||
|
|
||
| public class WebSocketCall { |
There was a problem hiding this comment.
This matches Call for testing, I guess.
|
LGTM. I'm not quite sure how this gets you where you're going, but the code looks good. |
Similar to HTTP and Call, the WebSocketCall is a representation of a pending HTTP request and subsequent upgrade to speak web sockets. Upon synchronous execution you are handed a WebSocket instance for synchronous writing and also pass in a WebSocketListener for async callbacks due to reading. The API changes in this commits also generalize WebSocket such that it's agnostic to being a client or server peer. Not implemented yet is an async version of the initial HTTP request (enqueue).
JakeWharton
force-pushed
the
jw/websocket-call
branch
from
60dbab2
to
5883bb5
Compare
| return; | ||
| } | ||
| WebSocketCall call = WebSocketCall.newWebSocketCall(client, request); | ||
| WebSocket webSocket = call.execute(this); |
There was a problem hiding this comment.
This might be a step backwards since you can no longer handle things like a 404 in calling code.
|
Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to HTTP and Call, the WebSocketCall is a representation of a pending HTTP request and subsequent upgrade to speak web sockets. Upon synchronous execution you are handed a WebSocket instance for synchronous writing and also pass in a WebSocketListener for async callbacks due to reading.
The API changes in this commits also generalize WebSocket such that it's agnostic to being a client or server peer.
Not implemented yet is an async version of the initial HTTP request (enqueue).
Closes #1173. Refs #193.