Use cache finally #1689
Closed
Use cache finally #1689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -342,7 +342,7 @@ InternalCache internalCache() { | |||
|
|
|||
| public OkHttpClient setCache(Cache cache) { | |||
| this.cache = cache; | |||
| this.internalCache = null; | |||
| this.internalCache = cache.internalCache; | |||
|
I don't follow this at all. Could you provide a failing test that this fixes? |
|
Ping on a failing test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having the same problem as discussed in #831
I noticed that
cacheandinternalCacheare both null forOkHttpClientinstance inHttpEngine::sendRequest().Also call
.setUseCaches(true)to jump over the check inHttpURLConnectionImpl::newHttpEngine()line 358.