Give the in-progress code a SNAPSHOT version number. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pforhan
added a commit
that referenced
this pull request
Jul 23, 2012
Give the in-progress code a SNAPSHOT version number.
JakeWharton
added a commit
that referenced
this pull request
May 6, 2013
Overview for the OkHttp website.
insights-service-dev1
pushed a commit
to InsightsDev-dev/okhttp-1
that referenced
this pull request
Nov 8, 2016
amirlivneh
added a commit
to amirlivneh/okhttp
that referenced
this pull request
Dec 25, 2018
There are usually 2 requests sent to '/b' during the test: square#1 on the busted connection, attempting reuse square#2 on a new connection On successful runs, the server records square#1 and then square#2 and adds them to the queue in that order. On failed runs, the server starts reading request square#1 before square#2, but there is a context switch, and it finishes reading square#2 before square#1, recording them in that order. Since square#1 is the last to be recorded, the test incorrectly uses it to assert that the sequence number is 0. Since square#1 was the second to be received on the busted connection, it has a sequence number of 1 so the test fails. The fix asserts that either square#1 or square#2 has a sequence number of 0.
amirlivneh
added a commit
to amirlivneh/okhttp
that referenced
this pull request
Dec 25, 2018
There are usually 2 requests sent to '/b' during the test: square#1 on the busted connection, attempting reuse square#2 on a new connection On successful runs, the server records square#1 and then square#2 and adds them to the queue in that order. On failed runs, the server starts reading request square#1 before square#2, but there is a context switch, and it finishes reading square#2 before square#1, recording them in that order. Since square#1 is the last to be recorded, the test incorrectly uses it to assert that the sequence number is 0. Since square#1 was the second to be received on the busted connection, it has a sequence number of 1 so the test fails. The fix asserts that either square#1 or square#2 has a sequence number of 0.
amirlivneh
added a commit
to amirlivneh/okhttp
that referenced
this pull request
Dec 25, 2018
There are usually 2 requests sent to '/b' during the test: square#1 on the busted connection, attempting reuse square#2 on a new connection On successful runs, the server recorded square#1 and then square#2 and added them to the queue in that order. On failed runs, the server started reading request square#1 before square#2, but there was a context switch, and it finished reading square#2 before square#1, recording them in that order. Since square#1 was the last to be recorded, the test incorrectly used it to assert that the sequence number is 0. Since square#1 was the second to be received on the busted connection, it had a sequence number of 1 so the test failed. The fix removes the assumption that we know the order in which square#1 and square#2 has been recorded.
amirlivneh
added a commit
to amirlivneh/okhttp
that referenced
this pull request
Dec 25, 2018
There are usually 2 requests sent to '/b' during the test: square#1 on the busted connection, attempting reuse square#2 on a new connection On successful runs, the server recorded square#1 and then square#2 and added them to the queue in that order. On failed runs, the server started reading request square#1 before square#2, but there was a context switch, and it finished reading square#2 before square#1, recording them in that order. Since square#1 was the last to be recorded, the test incorrectly used it to assert that the sequence number is 0. Since square#1 was the second to be received on the busted connection, it had a sequence number of 1 so the test failed. The fix removes the assumption that square#2 is the last to be recorded. Fixes square#4140.
amirlivneh
added a commit
to amirlivneh/okhttp
that referenced
this pull request
Dec 25, 2018
There are usually 2 requests sent to '/b' during the test: square#1 on the busted connection, attempting reuse square#2 on a new connection On successful runs, the server recorded square#1 and then square#2 and added them to the queue in that order. On failed runs, the server started reading request square#1 before square#2, but there was a context switch, and it finished reading square#2 before square#1, recording them in that order. Since square#1 was the last to be recorded, the test incorrectly used it to assert that the sequence number was 0. Since square#1 was the second to be received on the busted connection, it had a sequence number of 1 so the test failed. The fix removes the assumption that square#2 is the last to be recorded. Fixes square#4140.
elevenfive
added a commit
to elevenfive/okhttp
that referenced
this pull request
Sep 3, 2019
This was referenced Apr 7, 2022
Closed
Closed
This was referenced Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.