-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh the OkHttp cipher suite process #7393
Conversation
TODO Remove these entries and source from a clean record and checkin.
|
@swankjesse anywhere good to land? |
Likely no cipher changes for now. |
Some interesting additional sources |
@swankjesse It's noticeable given #6390 and #7452 That the intent of this process was not being honoured. |
Landing as sample code only |
Where are you referring to? |
} | ||
|
||
dependencies { | ||
implementation("com.squareup.okhttp3:okhttp:5.0.0-alpha.10") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including a dependency on the published OkHttp interferes pretty badly with IntelliJ. I’m gonna send a PR to remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -0,0 +1,13 @@ | |||
TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking these in in a machine-readable format is rad
*/ | ||
package okhttp3.survey.types | ||
|
||
data class Client( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE
import retrofit2.Retrofit | ||
import retrofit2.converter.moshi.MoshiConverterFactory | ||
|
||
class SslLabsScraper( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I slightly object to the word scraper here, as it suggests we’re doing something untoward?
The SSL labs people are awesome and offer their data under a generous creative commons license!
https://www.ssllabs.com/downloads/Qualys_SSL_Labs_Terms_of_Use.pdf
Lemme send a PR to rename this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick attempt at #4655
Starting from raw source files as much as possible.
SSL_ and TLS seems like an issue. Plus TLS1.3 ciphers are not enabled...