Post process md links in package-list files. #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deploy_website.sh
Outdated
| @@ -34,6 +34,10 @@ cd $DIR | |||
| :okhttp-urlconnection:dokkaGfm \ | |||
| :okhttp:dokkaGfm | |||
|
|
|||
| # mkdocs doesn't correctly handle the .md paths in package-list, so post-process. | |||
| # See https://github.com/square/okhttp/issues/7338 | |||
| find docs/4.x -name package-list -exec sed -i '' -e s/index.md$// -e s/\.md$/\\//g {} \; | |||
There was a problem hiding this comment.
Looks good, but I would tweak it slightly to do:
find docs/4.x -name package-list -exec sed -i '' -e 's/index.md$/index.html/' -e 's/\.md$/\.html/' -e '1 s/gfm/html/' -e '2 s/md/html/' {} \;
That keeps the index.html and also updates the first two lines to remove references to gfm and md. After those changes it produces the same text as my manually updated package-list.
colinrtwhite
approved these changes
Aug 22, 2022
yschimke
commented
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Dokka -> Mkdocs pipeline with md.
#fixes #7338 (comment)