Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce use_tmpcpy parameter to Library constructor. #172

Merged
merged 1 commit into from
May 1, 2023

Conversation

chanqueo
Copy link
Contributor

This parameter allow preventing temporary copy of J-Link Library.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2023

CLA assistant check
All committers have signed the CLA.

@chanqueo
Copy link
Contributor Author

This PR is a workaround for #166

@hkpeprah
Copy link
Contributor

This LGTM. Have you signed the CLA? I can't find it.

This parameter allow preventing temporary copy of J-Link Library.
@chanqueo chanqueo force-pushed the chanqueo/no-temp-library-copy branch from 8f9c65a to ff99e53 Compare April 23, 2023 11:45
@hkpeprah
Copy link
Contributor

Running tests now!

@hkpeprah hkpeprah self-requested a review May 1, 2023 15:42
@hkpeprah hkpeprah merged commit 6313307 into square:master May 1, 2023
@hkpeprah
Copy link
Contributor

hkpeprah commented May 9, 2023

v1.1.0 should have this change in it now; sorry for the delay, and thank you for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants