Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependnecies update #115

Merged
merged 4 commits into from
Jun 29, 2018
Merged

Dependnecies update #115

merged 4 commits into from
Jun 29, 2018

Conversation

alexgorbatchev
Copy link
Collaborator

@coveralls
Copy link

coveralls commented Jun 14, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 757

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.097%
Totals Coverage Status
Change from base Build 754: 0.0%
Covered Lines: 476
Relevant Lines: 699
💛 - Coveralls

@alexgorbatchev
Copy link
Collaborator Author

alexgorbatchev commented Jun 14, 2018 •
edited
Loading

@maniksurtani seems like a GO suite is failing, even though I haven't touched GO code... any ideas?

@alexgorbatchev
Copy link
Collaborator Author

ping @maniksurtani

@maniksurtani
Copy link
Collaborator

A couple of tests there are slightly flaky. Re-running...

@maniksurtani maniksurtani self-requested a review June 29, 2018 09:32
@maniksurtani maniksurtani merged commit 98a2ef8 into master Jun 29, 2018
@alexgorbatchev alexgorbatchev deleted the agorbatchev/dependnecies-update branch July 11, 2018 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniksurtani maniksurtani maniksurtani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgorbatchev @coveralls @maniksurtani