removal of unnecssary parsing if httpMethod is null #2218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Feb 25, 2017
| @@ -282,6 +282,8 @@ private void parseHttpMethodAndPath(String httpMethod, String value, boolean has | |||
| throw methodError("Only one HTTP method is allowed. Found: %s and %s.", | |||
| this.httpMethod, httpMethod); | |||
| } | |||
| if (null == httpMethod) return; | |||
There was a problem hiding this comment.
if we go through the code in the ServiceMethod build after parseMethodAnnotations , we are checking if httpMethod is null or not and then throwing the exception , so if we check at parseHttpMethodPath itself , we don't need to do value parsing for updating relativeUrl
|
The exception checks that the method isn't called twice. The value of
httpMethod is guaranteed to never be null by Java since it comes from an
annotation.
…On Sat, Feb 25, 2017, 12:23 AM guptasourabh ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In retrofit/src/main/java/retrofit2/ServiceMethod.java
<#2218 (comment)>:
> @@ -282,6 +282,8 @@ private void parseHttpMethodAndPath(String httpMethod, String value, boolean has
throw methodError("Only one HTTP method is allowed. Found: %s and %s.",
this.httpMethod, httpMethod);
}
+ if (null == httpMethod) return;
if we go through the code in the ServiceMethod build after
parseMethodAnnotations , we are checking if httpMethod is null or not and
then throwing the exception , so if we check at parseHttpMethodPath itself
, we don't need to do value parsing.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2218 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEb9dVqwIFvPesDIZHU4WQc4sZ3NQks5rf7rUgaJpZM4MLkxw>
.
|
|
@JakeWharton requested changes done |
|
Moved it into new PR #2219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If httpMethod is null then we don't need to parse and set the other values