Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify: Taiwan is not a Province of China #32

Merged
merged 2 commits into from
Feb 24, 2014
Merged

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Nov 1, 2013

Well it's a political and ISO 3166 problem. But anyway we don't recognize Taiwan as a Province of China, so it would be really nice to remove the suffix from Taiwan.

More info here:
http://www.change.org/petitions/iso-central-secretariat-change-the-present-taiwan-province-of-china-to-taiwan

Thanks!

Well it's a political and ISO 3166 problem. But anyway we don't recognize Taiwan as a Province of China, so it would be really nice to remove the suffix from Taiwan.  

More info here: 
http://www.change.org/petitions/iso-central-secretariat-change-the-present-taiwan-province-of-china-to-taiwan
@sarike
Copy link

sarike commented Nov 4, 2013

⊙﹏⊙b汗………………………………………………………………………………
你就不怕中国人喷你吗?
看你的头像貌似不像个外国人呀……
就算是,如果读不懂中文的话,用你的翻译系统翻一下吧……
权当是给你写了个测试用例……

@RickCSong
Copy link
Collaborator

Sorry @zhusee2, after a bit of debate, we've decided to stick with the ISO 3166 standard to try and remain as unpolitical about it as possible.

@RickCSong RickCSong closed this Feb 21, 2014
@Domon
Copy link

Domon commented Feb 22, 2014

I understand the decision the team has made. However, I don't view this as a political problem. It's just ignorance of reality. 😄

@muan
Copy link

muan commented Feb 22, 2014

In my personal opinion, sticking with Province of China is the most political decision you can make on this issue. Taiwan in itself is plenty enough as its geographical and international representation/identification. I am sure everyone can recognize Taiwan with showing just Taiwan.

@dlackty
Copy link
Contributor

dlackty commented Feb 22, 2014

@RickCSong @RISCfuture I agreed that sticking with ISO 3166 is an easy way for developers, but please realize that it's not an unpolitical way.

The truth is, Taiwan has its own political, postal, financial, and socioeconomic systems that is run independently. ISO 3166 standard is based on the data provided from UN, and due to historical reasons, Taiwan wasn't part of UN.

I've contributed to some Square OSS projects, and therefore I've signed CLA before. I believe there's no one that fills "Taiwan, Province of China" to country field as no one in Taiwan would ever say or agree that Taiwan is a province of China.

@itszero
Copy link

itszero commented Feb 22, 2014

I am pretty disappointed in the decision as well. As pointed out by the others, saying Province of China is a very political move. It's also very offending for Taiwanese people. Here's another way you can view this thing: how other people solve this problem?

As a matter of fact, most websites does not list Taiwan as a Province of China. Check out the Google Map, Twitter (in the settings), Facebook (payment settings, address), and for the sake of the argument: even Paypal got this right.

I hope the team could review this decision. Thanks. :)

@josephcc
Copy link

As a fellow developer from Taiwan, I do understand that it would seem sticking with a well defined standard is the right way to go, and I do understand that you feel like the project have no part in any political issues. However, please make no mistake, and understand, that this particular standard is nothing like the technical specs we are used to depend on. On the contrary, not only the term IS highly political, the standard itself has always had a lot of political debates and strong political influences around it. In many cases, it does not reflect the reality.

This is one of such cases. Being as "unpolitical" as possible, the reality is that for the past decades, we have been using our own currency, and we have voted for our own presidents. Labeling us in such way is not only ambiguous and confusing, but will also make us feel discriminated upon. Some people would even rather pick a random country than to select such label.

On the other hand, the label "Taiwan" is as "unpolitical" as you can go. As the previous comment pointed out, most major websites DO use this label, and I really don't think Facebook or Google or Paypal is taking a political stand in this issue.

I urge you to reconsider.

@vinta
Copy link

vinta commented Feb 22, 2014

@RISCfuture @RickCSong Many open source projects received bug reports like this one, you might want to know how they deal with this "ISO 3166" problem:

@itsarbit
Copy link

What a bad move for closing the issue by doing nothing. The decision of keeping Province of China is certainly a political move. Agree with @itszero , most of others do use Taiwan as an option. Hope the issue can be reopened.

@as1986
Copy link

as1986 commented Feb 23, 2014

'Taiwan' as a geographical identification is much more neutral, as it does not have any political connotation. Please reopen this issue.

@clkao
Copy link

clkao commented Feb 23, 2014

A common solution to this is using country codes from ISO 3166-1 along with entity names from the former FIPS PUB 10-4. The linked xls has an "APP B" sheet detailing all differences from ISO 3166-1

@RickCSong RickCSong reopened this Feb 24, 2014
RickCSong added a commit that referenced this pull request Feb 24, 2014
Clarify: Taiwan is not a Province of China
@RickCSong RickCSong merged commit 639dfa8 into square:master Feb 24, 2014
@RickCSong
Copy link
Collaborator

Thank you all for your feedback and insight! In particular, @vinta for sharing the various approaches that others have taken in the past which helped better guide our decision.

We originally thought that by sticking with the ISO, we'd be taking a "neutral/unpolitical" route, but this does not seem to be the case. Due to your feedback, we've decided on a stance much like FreeBSD and other major companies have and listed Taiwan as merely "Taiwan."

We're deeply sorry for any offense we have caused and thank you all again for your understanding!

@yhsiang
Copy link

yhsiang commented Feb 24, 2014

👍

@bluet
Copy link

bluet commented Feb 24, 2014

(Y)

@flaneur2020
Copy link

👍

@marsz
Copy link

marsz commented Feb 24, 2014

👍

@pohchen
Copy link

pohchen commented Feb 24, 2014

👍

@run26kimo
Copy link

👍

2 similar comments
@tonytonyjan
Copy link

👍

@cyan92128505
Copy link

👍

@ryudoawaru
Copy link

Good Job!

@sorarize
Copy link

👏

@hSATAC
Copy link

hSATAC commented Feb 24, 2014

💯

@josephcc
Copy link

Awesome!

@GGD
Copy link

GGD commented Feb 24, 2014

👍

3 similar comments
@moskytw
Copy link

moskytw commented Feb 24, 2014

👍

@Haraguroicha
Copy link

👍

@SarsTW
Copy link

SarsTW commented Feb 24, 2014

👍

@appleboy
Copy link

Good news.

@changwu-tw
Copy link

👍

@flaneur2020
Copy link

I'm a PRC guy, however I dislike the offensive description either.

@changmason
Copy link

👍

@aar0nTw
Copy link

aar0nTw commented Feb 25, 2014

💯

@Nelson119
Copy link

1014109_582810891793605_1097680276_n

@uranusjr
Copy link

❤️

@frostli
Copy link

frostli commented Apr 6, 2014

👍

longboardcat pushed a commit that referenced this pull request May 25, 2016
…ptions to master

* commit '2de6344ded23f939a00bfe75b45d47725e063be3':
  Resolve, subscribe and unsubscribe buttons for issues
  Move issue subscription on comment creation logic to the controller.
  Move sending 'comment_created' mail delivery to after_commit_on_create hook from after_create hook
  Pre-populating subscribed emails field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet