Skip to content
This repository has been archived by the owner on Aug 17, 2020. It is now read-only.

Implement processor for generating ContentValues. #16

Closed
wants to merge 1 commit into from
Closed

Implement processor for generating ContentValues. #16

wants to merge 1 commit into from

Conversation

ahmedre
Copy link
Contributor

@ahmedre ahmedre commented Feb 28, 2015

this is a pull request to implement #3 - it adds an annotation processor which generates code for generating ContentValues using a Builder pattern. The Builder is modeled as an interface, similar to the technique used by AutoValue. The @Table annotation is not used right now in and of itself (the processor looks directly for @Table.Builder), but i kept it there based on the assumption that this would expand as time goes on to support some of the other tickets.

@@ -0,0 +1 @@
/build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete file

@JakeWharton
Copy link
Member

Mostly just stylistic comments. This is a great start to the processor!

@ahmedre
Copy link
Contributor Author

ahmedre commented May 14, 2015

I realized now that I jumped the gun a little on this and submitted this request without fully understanding the vision of the project (which I now have a better sense of). In the future, I will propose a solution and get approval on the direction before actually submitting a pull request. I apologize for any inconvenience, and thank you for the review and for providing the community with this library!

@ahmedre ahmedre closed this May 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants