Read unknown enum tag #2934
Merged
Read unknown enum tag #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psymoon
approved these changes
May 9, 2024
swankjesse
approved these changes
May 10, 2024
| * the method will throw an [IOException]. | ||
| */ | ||
| @Throws(IOException::class) | ||
| inline fun <reified M : Message<M, B>, B : Message.Builder<M, B>, reified P : Enum<P>> Message<M, B>.unknownEnumTag(property: KProperty1<M, P?>): Int? { |
There was a problem hiding this comment.
I think we need to do the reflection machines thing here. Create something like this:
interface UnknownEnumTagReader<M, B, P> {
fun get(message: M): P?
}
That way we don’t have to do the KProperty reflection stuff each time we want to read a field
| * found but the value attached to it isn't a varint, the method will throw an [IOException]. | ||
| */ | ||
| @Throws(IOException::class) | ||
| inline fun <reified M : Message<M, B>, B : Message.Builder<M, B>, reified P : Enum<P>> Message<M, B>.unknownEnumTags(property: KProperty1<M, List<P>>): List<Int> { |
There was a problem hiding this comment.
This is for repeated properties?
There was a problem hiding this comment.
Yes, repeated MyEnum my_enums = 1
There was a problem hiding this comment.
I wanna rename it to unknownEnumValue and unknownEnumValues by the way.
oldergod
force-pushed
the
bquenaudon.2024-05-09.unknowntag
branch
2 times, most recently
from
bb2a410
to
4c401cf
Compare
|
@psymoon @swankjesse I did a big revamp following a pairing Jesse and I did. Please, have a look |
oldergod
force-pushed
the
bquenaudon.2024-05-09.unknowntag
branch
from
4c401cf
to
d8ad293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work for #2725